On Tue, Dec 13, 2022 at 10:59:47AM -0500, Brian Masney wrote: > I noticed another inconsistency with sc8280xp.dtsi compared to other > platforms. I left off all of the pin mappings in sc8280xp.dtsi and > added them to the sa8540-ride.dts file since the existing sc8280xp.dtsi > file contains no pin mappings. Other platforms such as sm8450.dtsi, > sm8350.dtsi, and sm8250.dtsi contain the geni pin mappings. My > understanding is that these geni pins are fixed within the SoC and > don't change with the different boards. Should I also add the geni > pin mappings to sc8280xp.dtsi? The pins are fixed but the pin configuration is still board specific. This came up earlier and we decided that keeping all pin configuration in the board dts was the way to go (e.g. for consistency and as it allows the integrator to easily review the actual configuration). Johan
