On 11/12/2022 19:13, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Thu, Dec 08, 2022 at 12:40:01PM +0200, Tomi Valkeinen wrote:
Add DT bindings for TI DS90UB913 FPDLink-3 Serializer.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
---
.../bindings/media/i2c/ti,ds90ub913.yaml | 121 ++++++++++++++++++
1 file changed, 121 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
new file mode 100644
index 000000000000..3a5b34c6bb64
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
@@ -0,0 +1,121 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub913.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DS90UB913 FPD-Link 3 Serializer
I think TI consistently writes it "FPD-Link III". If you rename it,
please do so through the whole series.
Indeed, good point.
+
+maintainers:
+ - Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
+
+description:
+ The TI DS90UB913 is an FPD-Link 3 video serializer for parallel video.
+
+properties:
+ compatible:
+ enum:
+ - ti,ds90ub913a-q1
Is the -q1 suffix needed, are there other variants ?
I'm not sure, but I couldn't see at a quick glance. I don't know what
the -q1 means. Even if many of the FPD-Link devices have -q1, there are
models without -q1, like DS90CF366. Oh, all those non-q1s seem to be
from Catalog, and -q1 versions from Automotive. But the -q1 seems to be
part of the model name, so... Maybe it's better to keep it.
https://www.ti.com/interface/high-speed-serdes/fpd-link-serdes/products.html
+
+ '#gpio-cells':
+ const: 2
+
+ gpio-controller: true
+
+ clocks:
+ maxItems: 1
+ description:
+ Reference clock connected to the CLKIN pin.
+
+ clock-names:
+ items:
+ - const: clkin
+
+ '#clock-cells':
+ const: 0
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: CSI-2 input port
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ unevaluatedProperties: false
+ description: FPD-Link 3 output port
I'd add
required:
- port@0
- port@1
Ok.
Tomi
