On 13/12/2022 14:07, Marek Vasut wrote: > The power-domains property is mandatory on i.MX8M Mini, Nano, Plus > and i.MX6SX, i.MX6SL. Document the property and mark it as required > on the aforementioned variants of the IP, present in those SoCs. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > --- > Cc: Fabio Estevam <festevam@xxxxxxxxx> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> > Cc: Liu Ying <victor.liu@xxxxxxx> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Cc: NXP Linux Team <linux-imx@xxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > To: devicetree@xxxxxxxxxxxxxxx > --- > V2: - Add AB from Krzysztof > - Add mx6sx power domain into the list > V3: - Update commit message > - Add i.MX6SL > - Update example > V4: - Drop ack from Krzysztof > - Rebase on next 20221213 instead of previous 20221208, which now > contains power-domains: part of this patch > --- > .../devicetree/bindings/display/fsl,lcdif.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index f449cfc767899..fd5aab93dd103 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -114,6 +114,19 @@ allOf: > maxItems: 1 > clock-names: > maxItems: 1 > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6sl-lcdif > + - fsl,imx6sx-lcdif > + - fsl,imx8mm-lcdif > + - fsl,imx8mn-lcdif > + - fsl,imx8mp-lcdif > + then: > + required: > + - power-domains Looks ok, but in such case please drop reguired:power-domains from the existing entry for fsl,imx8mp-lcdif. Best regards, Krzysztof