On Sun, Dec 11, 2022 at 11:51 PM Marek Vasut <marex@xxxxxxx> wrote:
>
> The power-domains property is mandatory on i.MX8M Mini, Nano, Plus
> and i.MX6SX, i.MX6SL. Document the property and mark it as required
> on the aforementioned variants of the IP, present in those SoCs.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> ---
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Liu Ying <victor.liu@xxxxxxx>
> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Cc: NXP Linux Team <linux-imx@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> To: devicetree@xxxxxxxxxxxxxxx
> ---
> V2: - Add AB from Krzysztof
> - Add mx6sx power domain into the list
> V3: - Update commit message
> - Add i.MX6SL
> - Update example
> ---
> .../devicetree/bindings/display/fsl,lcdif.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 876015a44a1e6..1f17be501749b 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -52,6 +52,9 @@ properties:
> interrupts:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
This conflicts with adding 'power-domains' for i.MX8MP in my tree.
> port:
> $ref: /schemas/graph.yaml#/properties/port
> description: The LCDIF output port
> @@ -87,6 +90,19 @@ allOf:
> maxItems: 1
> clock-names:
> maxItems: 1
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx6sl-lcdif
> + - fsl,imx6sx-lcdif
> + - fsl,imx8mm-lcdif
> + - fsl,imx8mn-lcdif
> + - fsl,imx8mp-lcdif
> + then:
> + required:
> + - power-domains
>
> examples:
> - |
> @@ -101,6 +117,7 @@ examples:
> <&clks IMX6SX_CLK_LCDIF_APB>,
> <&clks IMX6SX_CLK_DISPLAY_AXI>;
> clock-names = "pix", "axi", "disp_axi";
> + power-domains = <&pd_disp>;
>
> port {
> endpoint {
> --
> 2.35.1
>
