Re: [PATCH] arm64: dts: bullhead: add memory hole region

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10.12.2022 14:40, Dominik Kobinski wrote:
> Add region for memory hole present on bullhead in order to
> fix a reboot issue on recent kernels
> 
> Reported-by: Petr Vorel <petr.vorel@xxxxxxxxx>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> ---
It'd be better if the commit title said msm8992-bullhead instead of
just -bullhead.

>  arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> index 71e373b11de9d8..3cf40d8cfdf6eb 100644
> --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> @@ -2,6 +2,7 @@
>  /* Copyright (c) 2015, LGE Inc. All rights reserved.
>   * Copyright (c) 2016, The Linux Foundation. All rights reserved.
>   * Copyright (c) 2021, Petr Vorel <petr.vorel@xxxxxxxxx>
> + * Copyright (c) 2022, Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
>   */
>  
>  /dts-v1/;
> @@ -50,6 +51,11 @@
>  			reg = <0 0x03400000 0 0x1200000>;
>  			no-map;
>  		};
> +
> +		removed_region: memory@5000000 {
The memory node should not be named "memory", but something more
specific, "reserved" would fit this case. I know most DTs have
them as "memory", but that turned out to be just what we *aren't*
supposed to do :P

Konrad
> +			reg = <0 0x05000000 0 0x2200000>;
> +			no-map;
> +		};
>  	};
>  };



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux