On 08/12/2022 04:31, Trevor Wu wrote: > Add document for mt8188 board with mt6359. > > Signed-off-by: Trevor Wu <trevor.wu@xxxxxxxxxxxx> > --- > .../bindings/sound/mt8188-mt6359.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml > new file mode 100644 > index 000000000000..eac1c87b693a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml Missing vendor prefix. You got comments for it already. > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8188-mt6359.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT8188 ASoC sound card > + > +maintainers: > + - Trevor Wu <trevor.wu@xxxxxxxxxxxx> > + > +properties: > + compatible: > + const: mediatek,mt8188-mt6359-evb > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + sink/source pair of strings. Valid names could be the input or output > + widgets of audio components, power supplies, MicBias of codec and the > + software switch. > + > + mediatek,platform: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT8188 ASoC platform. > + > + mediatek,dptx-codec: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT8188 Display Port Tx codec node. > + > + mediatek,hdmi-codec: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT8188 HDMI codec node. Why you do not use DAI links for all these? > + > +additionalProperties: false > + > +required: > + - compatible > + - mediatek,platform > + > +examples: > + - | > + Drop blank line. > + sound: mt8188-sound { Drop label, not used. Use generic node names, so just "sound". > + compatible = "mediatek,mt8188-mt6359-evb"; Best regards, Krzysztof
