Hi Linus and Fabio, Thanks for your time to review this patch! On Thu, Dec 08, 2022 at 10:37:36PM +0100, Linus Walleij wrote: > On Thu, Dec 8, 2022 at 12:04 AM Fabio Estevam <festevam@xxxxxxxxx> wrote: > > > In other imx8m pinctrl drivers we pass: > (...) > > > +module_platform_driver(s32g_pinctrl_driver); > > > > And we also register it in arch_initcall() level. > > Do you really need that though? This driver certainly does not. > > I was under the impression that recent changes to the probe-order > logic has made most explicit arch_ etc initcall orderings surplus. > Could bool/tristate options in the Kconfig be the key point? Based on current design I prefer to build the s32g2 pinctrl driver as built-in rather than a loadable module. IIUC, when the driver is not built as module then the initcall ordering should still matter. Feel free to correct me if anything wrong. Regards, Chester > Yours, > Linus Walleij
