Re: [PATCH v5 0/8] i2c-atr and FPDLink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 08, 2022 at 12:42:13PM +0200, Tomi Valkeinen wrote:
> On 08/12/2022 12:39, Tomi Valkeinen wrote:

...

> +#include <linux/fwnode.h>
>  #include <linux/i2c-atr.h>
>  #include <linux/i2c.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
> -#include <linux/of.h>
>  #include <linux/slab.h>

+ Blank line here?

> +#define ATR_MAX_ADAPTERS 99	/* Just a sanity limit */
> +#define ATR_MAX_SYMLINK_LEN 16	/* Longest name is 10 chars: "channel-99" */

...

> +		u16 *new_buf;
> +
> +		new_buf = kmalloc_array(num, sizeof(chan->orig_addrs[0]),
> +					GFP_KERNEL);

		new_buf = kmalloc_array(num, sizeof(*new_buf), GFP_KERNEL);

?

> +		if (!new_buf)
>  			return -ENOMEM;

...

>  	struct i2c_atr_cli2alias_pair *c2a;
> -	u16 alias_id = 0;
> -	int ret = 0;
> +	u16 alias_id;
> +	int ret;

Is it mangled or it's missing blank line here?

>  	c2a = kzalloc(sizeof(*c2a), GFP_KERNEL);
>  	if (!c2a)

...

>  struct device;
>  struct i2c_atr;
> +struct fwnode_handle;

Order?

...

>  /**
> - * Helper to add I2C ATR features to a device driver.
> + * struct i2c_atr - Represents the I2C ATR instance
>   */

This is incomplete. Have you run kernel doc validator against this file?

>  struct i2c_atr {

>  };

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux