On 2022/12/7 22:46, Conor Dooley wrote: > On Wed, Dec 07, 2022 at 08:19:49AM -0600, Rob Herring wrote: >> >> On Wed, 07 Dec 2022 21:17:29 +0800, William Qiu wrote: >> > Add documentation to describe StarFive >> > designware mobile storage host controller driver. >> > >> > Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> >> > --- >> > .../bindings/mmc/starfive,jh7110-sdio.yaml | 71 +++++++++++++++++++ >> > 1 file changed, 71 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/mmc/starfive,jh7110-sdio.yaml >> > >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Documentation/devicetree/bindings/mmc/starfive,jh7110-sdio.example.dts:21:18: fatal error: dt-bindings/clock/starfive-jh7110.h: No such file or directory >> 21 | #include <dt-bindings/clock/starfive-jh7110.h> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Hello William, > As with the other bindings that StarFive has sent out recently, > including this header in the example creates a dependency on the > clock/reset stuff being merged prior to the drivers for unrelated > subsytems. > To avoid that, you can drop the headers & definitions from these > *examples* & use the numbers themselves instead. > > That way, the only thing that depends on the clock binding headers is > the DeviceTree patch & the driver can be merged once it is ready. > > Thanks, > Conor. > Hi Conor, Thank you for your suggestion. I will take it and fix it. Best regards, William Qiu >> compilation terminated. >> make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/mmc/starfive,jh7110-sdio.example.dtb] Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [Makefile:1492: dt_binding_check] Error 2 >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207131731.1291517-2-william.qiu@xxxxxxxxxxxxxxxx >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >>
