Re: [PATCH v9 1/2] memory: omap-gpmc: wait pin additions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tony,
On Wed, 2022-12-07 at 17:06 +0200, Tony Lindgren wrote:
> * Niedermayr, BENEDIKT <benedikt.niedermayr@xxxxxxxxxxx> [221207 14:52]:
> > Hi Tony,
> > 
> > On Wed, 2022-12-07 at 15:51 +0200, Tony Lindgren wrote:
> > > Hi,
> > > 
> > > * B. Niedermayr <benedikt.niedermayr@xxxxxxxxxxx> [221102 13:21]:
> > > > From: Benedikt Niedermayr <benedikt.niedermayr@xxxxxxxxxxx>
> > > > 
> > > > This patch introduces support for setting the wait-pin polarity as well
> > > > as using the same wait-pin for different CS regions.
> > > 
> > > Looks like Linux next commit 89aed3cd5cb9 ("memory: omap-gpmc: wait pin
> > > additions") breaks the old smsc911x using devices somehow for nfsroot.
> > > 
> > Can you explain how this breaking change looks like, in bit more detail?
> > I'm a bit confused since the changes on omap-gpmc have nothing in common with
> > smsc911x. 
> 
> The smsc911x device is on gpmc. It's not found with this change.
> See arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi for the configuration.
Thanks for the configuration example. 

I found the cause of this bug.
At least when "gpmc_cs_program_settings: invalid wait-pin (-1)" is printed in the kernel log.

Now I'm not sure where to send the bugfix patch (linux-next, linux-omap, both?). 

> 
> Regards,
> 
> Tony

cheers,
benedikt





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux