On Tue, Dec 06, 2022 at 01:44:55PM +0100, Edmund Berenson wrote: > Add driver bindings for the maxim max7317 spi > gpio expander. Bindings are for h/w, not drivers. s/maxim/Maxim/ s/spi/SPI/ For the subject, no need to say 'bindings' twice: dt-bindings: gpio: Add Maxim max7317 GPIO expander > > Co-developed-by: Lukasz Zemla <Lukasz.Zemla@xxxxxxxxxxxx> > Signed-off-by: Lukasz Zemla <Lukasz.Zemla@xxxxxxxxxxxx> > Signed-off-by: Edmund Berenson <edmund.berenson@xxxxxxxxx> > --- > .../bindings/gpio/gpio-max7317.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-max7317.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-max7317.yaml b/Documentation/devicetree/bindings/gpio/gpio-max7317.yaml > new file mode 100644 > index 000000000000..88f1fe02a627 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-max7317.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/gpio-max7317.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX7317 SPI-Interfaced I/O Expander > + > +description: | Don't need '|' > + Bindings for 10-Port Maxim MAX7317 SPI GPIO expanders. > + > +properties: > + compatible: > + const: maxim,max7317 > + > + reg: > + maxItems: 1 > + > + gpio-controller: true > + > + '#gpio-cells': > + const: 2 > + > + gpio-line-names: > + minItems: 1 > + maxItems: 10 > + > +required: > + - compatible > + - reg > + - gpio-controller > + - "#gpio-cells" > + > +additionalProperties: false unevaluatedProperties: false Or the $ref below doesn't work. > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + gpio5: gpio5@0 { gpio@0 { > + compatible = "maxim,max7317"; > + reg = <0>; > + gpio-controller; > + #gpio-cells = <2>; > + spi-max-frequency = <100000>; > + }; > + }; > -- > 2.37.4 > >