Hi Krzysztof, On Mon, 2022-12-05 at 10:21 +0100, Krzysztof Kozlowski wrote: > On 05/12/2022 07:57, Xiangsheng Hou wrote: > > 1. Split MediaTek ECC engine with rawnand controller and convert to > > YAML schema. > > 2. Change the existing node name in order to match NAND controller > > DT > > bindings. > > One patch - one logical change. Not two. This applies to all your > patches, so whenever you want to enumerate, please think twice. Will be corrected in next series. > > > > > Signed-off-by: Xiangsheng Hou <xiangsheng.hou@xxxxxxxxxxxx> > > --- > > .../bindings/mtd/mediatek,mtk-nfc.yaml | 171 > > +++++++++++++++++ > > .../mtd/mediatek,nand-ecc-engine.yaml | 62 ++++++ > > .../devicetree/bindings/mtd/mtk-nand.txt | 176 -------------- > > ---- > > arch/arm/boot/dts/mt2701.dtsi | 2 +- > > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 +- > > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +- > > Do not combine bindings and DTS. The DTS modification will be separated. > > > > + > > + ecc-engine: true > > I don't think this could be anything. You need to describe it, so > $ref > and description. Will do. > > + > > + partitions: > > + $ref: mtd.yaml# > > How the partitions are MTD device? Open that file and see how it > should > be defined... Anyway mtd.yaml is part of nand-chip, not nand- > controller. This will be dropped in next series since nand-chip is part of nand- controller. > > + > > +allOf: > > + - $ref: nand-controller.yaml# > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: mediatek,mt2701-nfc > > + then: > > + patternProperties: > > + "^nand@[a-f0-9]$": > > + type: object > > No need for type, the definition is already there through > nand-controller.yaml. > > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 1 > > This is the same as other variant, so should be defined in top-level > pattern properties. > > > + nand-ecc-mode: > > + const: hw > > Ditto Will be fixed in next series. Thanks Xiangsheng Hou
