Re: [PATCH v3 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Robert,

On 5.12.22 18:37, Robert Foss wrote:
Use two interconnect cells in order to optionally
support a path tag.

Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++++++++++++++--------------
  1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 805d53d91952..434f8e8b12c1 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -1543,56 +1543,56 @@ apps_smmu: iommu@15000000 {
  		config_noc: interconnect@1500000 {
  			compatible = "qcom,sm8350-config-noc";
  			reg = <0 0x01500000 0 0xa580>;
-			#interconnect-cells = <1>;
+			#interconnect-cells = <2>;
  			qcom,bcm-voters = <&apps_bcm_voter>;
  		};
mc_virt: interconnect@1580000 {
  			compatible = "qcom,sm8350-mc-virt";
  			reg = <0 0x01580000 0 0x1000>;
-			#interconnect-cells = <1>;
+			#interconnect-cells = <2>;
  			qcom,bcm-voters = <&apps_bcm_voter>;
  		};
[..]
@@ -1620,8 +1620,8 @@ ipa: ipa@1e40000 {
  			clocks = <&rpmhcc RPMH_IPA_CLK>;
  			clock-names = "core";
- interconnects = <&aggre2_noc MASTER_IPA &mc_virt SLAVE_EBI1>,
-					<&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_IPA_CFG>;
+			interconnects = <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>,
+					<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>;
  			interconnect-names = "memory",
  					     "config";
@@ -1661,7 +1661,7 @@ mpss: remoteproc@4080000 {
  					<&rpmhpd SM8350_MSS>;
  			power-domain-names = "cx", "mss";
- interconnects = <&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1>;
+			interconnects = <&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1 0>;

The second cell for the first endpoint is missing, so this should be:
	interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>;

Thanks,
Georgi

memory-region = <&pil_modem_mem>; @@ -2239,7 +2239,7 @@ cdsp: remoteproc@98900000 {
  					<&rpmhpd SM8350_MXC>;
  			power-domain-names = "cx", "mxc";
- interconnects = <&compute_noc MASTER_CDSP_PROC &mc_virt SLAVE_EBI1>;
+			interconnects = <&compute_noc MASTER_CDSP_PROC 0 &mc_virt SLAVE_EBI1 0>;
memory-region = <&pil_cdsp_mem>; @@ -2421,14 +2421,14 @@ usb_2_ssphy: phy@88ebe00 {
  		dc_noc: interconnect@90c0000 {
  			compatible = "qcom,sm8350-dc-noc";
  			reg = <0 0x090c0000 0 0x4200>;
-			#interconnect-cells = <1>;
+			#interconnect-cells = <2>;
  			qcom,bcm-voters = <&apps_bcm_voter>;
  		};
gem_noc: interconnect@9100000 {
  			compatible = "qcom,sm8350-gem-noc";
  			reg = <0 0x09100000 0 0xb4000>;
-			#interconnect-cells = <1>;
+			#interconnect-cells = <2>;
  			qcom,bcm-voters = <&apps_bcm_voter>;
  		};




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux