On Mon, Dec 05, 2022 at 10:20:11AM +0000, Potthuri, Sai Krishna wrote:
> As we communicated earlier for ZynqMP platform we have both Synopsys
> (for DDRMC) and zynqmp_ocm_edac (for OCM) drivers. Just to be clear
> about what this driver is targeted for, we used ocm as part of file
> name. Ok, zynqmp_edac.c looks fine, will update.
Yeah, we can always rename later, when another driver is needed. For
now, let's keep things simple.
> Ok, will update API documentation like below.
> echo <fault_injection count> > /sys/kernel/debug/edac/ff960000.memory-controller/inject_fault_count
^^^^^^^^^^^^^^^^^^^^^^^^^^
Any particular reason this should not be called simply "mc0" or so?
At least this is how we call them on x86...
> echo <bit pos0> <bit pos1> > /sys/kernel/debug/edac/ff960000.memory-controller/inject_ue_bitpos
echo <bit0>,<bit1> > ...
I guess.
The ',' or ':' or some other separator which is not blank space would
make it more obvious that the two bits belong together and you won't
have to scan further for the second value but simply have a single
string which you split at the separator.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
