On 2022/12/5 15:30, Krzysztof Kozlowski wrote: > On 05/12/2022 04:49, Xingyu Wu wrote: >> On 2022/12/2 18:46, Krzysztof Kozlowski wrote: >>> On 02/12/2022 10:39, xingu.wu wrote: >>>> From: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> >>>> >>>> Add bindings to describe the watchdog for the StarFive SoCs. >>>> >>>> Signed-off-by: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> >>>> --- >>>> .../bindings/watchdog/starfive,wdt.yaml | 77 +++++++++++++++++++ >>>> 1 file changed, 77 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml >>>> new file mode 100644 >>>> index 000000000000..ece3e80153a0 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml >>> >>> Filename should be based on compatible. You do not allow here any other >>> models... If you intent and you are 100% sure you will grow with new >>> models, make it maybe a family-based name. >> >> First, thank you for your reply. We have some other SoCs like JH7100 would use >> this watchdog driver, but we now use JH7110 as our main release chip. >> As you say, should we use "starfive,jh71xx-wdt.yaml" as filename? > > starfive,jh7110-wdt.yaml > I would say because you do not expect any other models (const for > compatible, not enum) > Thanks, I will rename the file in the patches for next version. Best regards, Xingyu Wu
