Re: [PATCH v3 1/3] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/12/2022 17:18, Doug Anderson wrote:
> Hi,
> 
> On Fri, Dec 2, 2022 at 8:08 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>>
>> Hi,
>>
>> On Fri, Dec 2, 2022 at 7:57 AM Krzysztof Kozlowski
>> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>>
>>> The pin config entry should have a string, not number, for the GPIO used
>>> as WCD9340 audio codec interrupt.
>>>
>>> Reported-by: Doug Anderson <dianders@xxxxxxxxxxxx>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>>
>>> ---
>>>
>>> Cc: Doug Anderson <dianders@xxxxxxxxxxxx>
>>>
>>> Changes since v2:
>>> 1. New patch.
>>> ---
>>>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Presumably should have a "Fixes" tag since this is likely a true bug.
>>
>> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> 
> FWIW, this got copy-pasta-ed to another place, which I just noticed as
> I'm looking at your v3. So while your change is correct, it'd be
> better to also fix "sdm845-xiaomi-beryllium-common.dtsi"

Yep...

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux