On Wed, 2014-10-29 at 17:32 +0200, Ivan T. Ivanov wrote: > + > > > + chip->tz_dev = thermal_zone_device_register(node->name, TRIP_NUM, 0, > > > + chip, &qpnp_tz_ops, NULL, > > > > Have you considered using of-thermal instead of doing your own specific thermal > > zone registration? Having a glance look in this driver, most of the > > operation are covered by of-thermal. Ahy concerns using of-thermal in > > your case? > > > > I just followed implementation found in "armada_thermal", "db8500-thermal", > "dove_thermal", "imx_thermal", "kirkwood_thermal"... > > Will look at of-thermal. > Hm, the 15 drivers, which register its own thermal zone, against 4, which use of-thermal registration and one of them is OMAP, which have fallback to its own zone registration :-). Anyway. I am afraid that if I use just thermal_zone_of_sensor_register(), driver will lost ability to switch off hardware controlled shutdown sequence, which make it useless IMHO. I don't see how driver can benefits from nice things provided by of-thermal. There is no colling device associated with PMIC chip, pooling delays are of no use, device uses interrupt, trip pints are predefined in hardware... Please advice. Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
