On 2022/12/02 21:08, Krzysztof Kozlowski wrote:
On 01/12/2022 10:30, Kunihiko Hayashi wrote:
Hi Krzysztof,
On 2022/11/29 19:35, Kunihiko Hayashi wrote:
Add DT binding schema for components belonging to the platform-specific
AHCI glue layer implemented in UniPhier SoCs.
This AHCI glue layer works as a sideband logic for the host controller,
including core reset, PHYs, and some signals to the controller.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
(snip)
+examples:
+ - |
+ sata-controller@65700000 {
+ compatible = "socionext,uniphier-pxs3-ahci-glue", "simple-mfd";
+ reg = <0x65b00000 0x400>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x65700000 0x100>;
In PATCH 7/8, you suggested that the node name of "USB glue layer" should
changes to the generic node name "usb@...".
However, in case of this "AHCI glue layer", I can't change
"sata-controller"
to the generic node name "sata@...", because ata/sata-common.yaml has
pattern
"^sata(@.*)?$", and the changed node matches this pattern unintentionally.
This layer isn't a sata host controller, so it's hard to give a generic
name
to this node. I'd like you opinion.
Yeah, I think it's fine. We do not have good names for such nodes.
OK, I leave the name for this node.
Thank you,
---
Best Regards
Kunihiko Hayashi
