On 01/12/22 17:43, Krzysztof Kozlowski wrote:
On 01/12/2022 17:38, Saravanan Sekar wrote:
Plus additional comment for the driver (and related to bindings) was
that this is not hwmon but a regulator driver. Why putting regulator
driver in hwmon?
Turns out this is primarily a hardware monitoring driver, like the drivers
for all other PMBus chips. Regulator support is actually optional; the driver
works perfectly well with CONFIG_REGULATOR=n (except that it needs some
#ifdefs to address that situation).
OK, this would explain location of the driver. However the bindings are
saying:
"Monolithic Power System MPQ7932 PMIC"
and PMIC is not mainly a hwmon device, even if it has such capabilities.
It might be missing description and proper title... or might be misplaced.
Indeed it is PMIC chip. I think this is not the first and not sure title
has to be changed for hwmon subsystem.
bindings/hwmon/pmbus/ti,lm25066.yaml
title: National Semiconductor/Texas Instruments LM250x6/LM506x
power-management ICs
Then I propose to put it in regulator directory.
Just for clarification, should bindings put in regulator directory?
Thanks,
Saravanan
