Hi, On Tue, Nov 29, 2022 at 10:30 PM Owen Yang <ecs.taipeikernel@xxxxxxxxx> wrote: > > +&pm8350c_pwm_backlight{ > + pwms = <&pm8350c_pwm 3 200000>; > +}; This is in the right location now, but previously I mentioned that it would be nice to have a comment explaining what you're doing. In other words, I wish the above was something like: &pm8350c_pwm_backlight{ /* Set the PWM period to 200 microseconds (5kHz duty cycle) pwms = <&pm8350c_pwm 3 200000>; }; If you spin a v11 with that change feel free to add my Reviewed-by tag. -Doug