On 29/11/2022 19:04, Uwe Kleine-König wrote: > Compared to the txt description this adds clocks and clock-names to > match reality. (...) > + > +maintainers: > + - Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > + - Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx1-fb > + - fsl,imx21-fb > + - items: > + - enum: > + - fsl,imx25-fb > + - fsl,imx27-fb > + - const: fsl,imx21-fb > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: ipg > + - const: ahb > + - const: per > + > + display: > + $ref: /schemas/types.yaml#/definitions/phandle You could mention here in "description" expected properties of display, just like original binding. Anyway, looks good: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
