On Wed, Nov 30, 2022 at 10:04:41AM +0100, Gerald Loacker wrote: > Am 29.11.2022 um 17:37 schrieb Andy Shevchenko: > > On Tue, Nov 29, 2022 at 07:45:40AM +0100, Gerald Loacker wrote: ... > >> + snprintf(data->name, sizeof(data->name), "tmag5273x%1u", data->version); > > > > Thinking more about this format, perhaps > > > > snprintf(data->name, sizeof(data->name), "tmag5273x-v%1u", data->version); > > > > ? > > I'd prefer to keep this as it's related to the orderable part number, > e.g. TMAG5273A1 / TMAG5273A2. I see, can you add a comment above to clarify the chosen format? -- With Best Regards, Andy Shevchenko