On 29/11/2022 16:30, Ulf Hansson wrote: > On Tue, 29 Nov 2022 at 13:36, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 22/11/2022 12:11, Christoph Niedermaier wrote: >>> The current comment on wakeup-source is a bit confusing, because it isn't >>> clear at first sight which property is actually deprecated. >>> Change the comment to one that is less confusing. >> >> It's still confusing - you mention some non-existing property. I don't >> think it's worth to touch it. If you insist, drop entire comment... > > Hmm, it doesn't look that easy to me. The "enable-sdio-wakeup" is > indeed a deprecated wakeup property [1], but it seems like it's not > really described somewhere. I wouldn't mind removing it (as it seems > to add some confusions), but in that case it needs to be entirely > removed from the DT docs, right? Yes, from the bindings and from DTSes. It's already gone from mmc-controller.yaml bindings, so basically we already did the most of such removal. > > Another option, would be to add a proper description of the property > and mark it with "deprecated: true". Best regards, Krzysztof
