Re: [PATCH 8/8] dt-bindings: mmc: sdhci-pxa: add pxav1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof and Rob,

On 11/28/2022 12:58 AM, Krzysztof Kozlowski wrote:

No need for minItems.

Start with capital letter if this is a sentence with full stop. It's
anyway looking different then the rest of the file, right?

Why maxItems: 1? What if one wants to add here more entries? Drop maxItems.

Ditto

Thanks for the fast review. Will fix this all in V2 after I receive
feedback on the other patches. I was trying to follow the pattern from
another similar schema and didn't fully understand.

On 11/28/2022 4:20 AM, Rob Herring wrote:

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13)
Well this is embarrassing! I forgot to run dt_binding_check. Sorry about
that.

Doug



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux