Re: [PATCH v8 1/2] gpio: loongson: add gpio driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2022/11/29 4:35, Linus Walleij 写道:
On Mon, Nov 28, 2022 at 7:43 AM Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> wrote:

The Loongson platforms GPIO controller contains 60 GPIO pins in total,
4 of which are dedicated GPIO pins, and the remaining 56 are reused
with other functions. Each GPIO can set input/output and has the
interrupt capability.

This driver added support for Loongson GPIO controller and support to
use DTS or ACPI to descibe GPIO device resources.

Signed-off-by: Jianmin Lv <lvjianmin@xxxxxxxxxxx>
Signed-off-by: Hongchen Zhang <zhanghongchen@xxxxxxxxxxx>
Signed-off-by: Liu Peibao <liupeibao@xxxxxxxxxxx>
Signed-off-by: Juxin Gao <gaojuxin@xxxxxxxxxxx>
Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
v8 looks really nice.

+static int loongson_gpio_to_irq(
+                       struct gpio_chip *chip, unsigned int offset)
+{
+       struct platform_device *pdev =
+               container_of(chip->parent, struct platform_device, dev);
+
+       if (offset >= chip->ngpio)
+               return -EINVAL;
You forgot to drop this.

You mean to remove this if judgment?

"if(offset >= chip->ngpio)"

        return -EINVAL;


With this fixed (and Bartosz requested fix):
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux