Hi Krzysztof:
在 2022/11/28 04:49, Krzysztof Kozlowski 写道:
On 25/11/2022 09:54, Binbin Zhou wrote:
Add device tree bindings for the i2c controller on the Loongson-2K Soc
or Loongosn LS7A bridge.
It's a v3 which is for the first time sent to DT maintainers...
Sorry, it was my mistake, I didn't double check the mail recipients in
my .git/config.
Subject: drop second, redundant "bindings for".
Ok. I get it.
Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
---
.../bindings/i2c/loongson,ls2x-i2c.yaml | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
diff --git a/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml b/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
new file mode 100644
index 000000000000..8c785f329d2f
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/i2c/loongson,ls2x-i2c.yaml#";
+$schema: "http://devicetree.org/meta-schemas/core.yaml#";
Drop quotes form both.
+
+title: Loongson LS2X I2C Controller
+
+maintainers:
+ - Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ compatible:
+ enum:
+ - loongson,ls2k-i2c # Loongson-2K SoCs
+ - loongson,ls7a-i2c # Loongson LS7A Bridge
Isn't your comment exactly the same as compatible? Where is the
difference? I propose to drop the comment entirely, unless it explains
something.
OK, I will drop the useless comment.
+
+ reg:
+ maxItems: 1
+
No clocks? I2C controller without clocks? Are you sure the binding is
complete?
We previously set the default CLOCK in the driver. Of course, we also
provide the path to read the clock-frequency field for redo. In any
case, I will add the clock-frequency field to the V4 patchset.
Thanks for your review.
Binbin
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
Best regards,
Krzysztof
