On 28/11/2022 03:06, Xiangsheng Hou wrote: > add rx-sample-delay and rx-latch-latency property. Start sentences with capital letter. Here and in commit subject: property->properties > > Signed-off-by: Xiangsheng Hou <xiangsheng.hou@xxxxxxxxxxxx> > --- > .../bindings/spi/mediatek,spi-mtk-snfi.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > index ee20075cd0e7..367862688e92 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > @@ -55,6 +55,22 @@ properties: > description: device-tree node of the accompanying ECC engine. > $ref: /schemas/types.yaml#/definitions/phandle > > + rx-sample-delay: No, use existing property, don't invent your own stuff - missing unit suffix. See spi-peripheral-props.yaml. > + description: Rx delay to sample data with this value, the valid > + values are from 0 to 47. The delay is smaller than > + the rx-latch-latency. > + $ref: /schemas/types.yaml#/definitions/uint32 Drop $ref. > + minItems: 0 > + maxItems: 47 > + default: 0 > + > + rx-latch-latency: Same problems. Did you check spi-peripheral-props.yaml or other SPI controller schemas for such property? > + description: Rx delay to sample data with this value, the value > + unit is clock cycle. I think the unit should be rather time (e.g. us). > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3] > + default: 0 > + > required: > - compatible > - reg Best regards, Krzysztof
