On 27/11/2022 22:25, Dmitry Baryshkov wrote: > On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@xxxxxxxxx> wrote: >> >> Document the OnePlus One ("bacon") which is a smartphone based on the >> Snapdragon 801 SoC. >> >> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. > > The patch itself is good. However it raised a broader question for me. > Up to now all msm8974pro devices use qcom,msm8974 as a top-level > compatibility string. Should it be changed to use pro-specific one > (e.g. qcom,msm8974pro)? Yes, makes sense. Best regards, Krzysztof