On Thu, 24 Nov 2022 at 15:06, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 23/11/2022 17:35, Jagan Teki wrote:
>
> >>>>> + aliases {
> >>>>> + i2c0 = &i2c0;
> >>>>> + serial0 = &uart0;
> >>>>> + serial1 = &uart1;
> >>>>> + serial2 = &uart2;
> >>>>> + serial3 = &uart3;
> >>>>> + serial4 = &uart4;
> >>>>> + serial5 = &uart5;
> >>>>
> >>>> These are not properties of a SoC but board. They depend on the
> >>>> particular routing on the board... unless this SoC is an exception from
> >>>> all others?
> >>>
> >>> Was this a new feature to follow, didn't see this before at least
> >>> rockchip SoC's.
> >>>
> >>
> >> It's not exactly new comment, but rather not always enforced/given.
> >
> > It seems like i2c0 and serial aliases are required across SoC instead
> > of the specific board. An example of which i2c0 connected via PMIC
> > which indeed require aliases to get a probe, which is common across
> > SoC.
> >
> > [ 1.778941] i2c_dev: i2c /dev entries driver
> > [ 1.780877] rk3x-i2c ff3f0000.i2c: rk3x-i2c needs i2cX alias
> > [ 1.781410] rk3x-i2c: probe of ff3f0000.i2c failed with error -22
> > [ 1.791312] Bluetooth: HCI UART driver ver 2.3
>
> I2C driver indeed seems to require them, so then it's fine. That's not
> the argument for serials though.
Yes, I dropped serial aliases for the next version.
Jagan,
