On 25/11/2022 21:20, Samuel Holland wrote: > The sun8i-emac binding extends snps,dwmac.yaml, and should accept all > properties defined there, including "mdio", "resets", and "reset-names". > However, validation currently fails for these properties because the validation does not fail: make dt_binding_check -> no problems Maybe you meant that DTS do not pass dtbs_check? > local binding sets "unevaluatedProperties: false", and snps,dwmac.yaml > is only included inside an allOf block. Fix this by referencing > snps,dwmac.yaml at the top level. There is nothing being fixed here... > > Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx> > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > index 1432fda3b603..34a47922296d 100644 > --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > @@ -10,6 +10,8 @@ maintainers: > - Chen-Yu Tsai <wens@xxxxxxxx> > - Maxime Ripard <mripard@xxxxxxxxxx> > > +$ref: "snps,dwmac.yaml#" > + > properties: > compatible: > oneOf: > @@ -60,7 +62,6 @@ required: > - syscon > > allOf: > - - $ref: "snps,dwmac.yaml#" > - if: > properties: > compatible: Best regards, Krzysztof