On Thu, Nov 24, 2022 at 08:05:40PM +0000, Conor Dooley wrote: > On Thu, Nov 24, 2022 at 08:58:41PM +0100, Heiko Stübner wrote: > > Am Donnerstag, 24. November 2022, 20:52:33 CET schrieb Conor Dooley: > > > On Thu, Nov 24, 2022 at 05:22:01PM +0000, Prabhakar wrote: > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > > > Introduce ALTERNATIVE_3() macro. > > > > > > Bit perfunctory I think! There's a lovely comment down below that would > > > make for a better commit message if you were to yoink it. > > > Content looks about what I'd expect to see though. > > > > Also both the comment on the original ALTERNATIVE_2 and the new ALTERNATIVE_3 > > should probably be merged into a single comment explaining this once for all > > ALTERNATIVE_x variants. > > > > Especially with the dma stuff, I'm pretty sure we'll get at least an ALTERNATIVE_4 > > if not even more ;-) . So we defnitly don't want to repeat this multiple times. > > Oh I can promise you that there'll be a #4 ;) I took a stab[*] at cleaning up alternative-macros.h a bit in order to prepare for _3, _4, ..., _42. The idea was to try and find a way to reduce as much duplication as possible, both in the current code and in the new macros. [*] https://lore.kernel.org/all/20221125113959.35328-1-ajones@xxxxxxxxxxxxxxxx/ Thanks, drew
