On 25.11.2022 12:01, Horatiu Vultur - M31836 wrote: > The 11/25/2022 09:23, Claudiu Beznea - M18063 wrote: >> Hi, Horatiu, > > Hi Claudiu, > >> >> On 16.09.2022 22:49, Horatiu Vultur wrote: >>> Add OTP (one time programmable) support. >>> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP. >> >> If OTP IP is the same for both lan966x is there a reason you've added >> compatibles for each SoC variants? > > When I was adding the device tree binding, Krzystof mention not to have > any wilcards in compatible string [0]. I was thinking at having only one of microchip,lan9668-otpc or microchip,lan9662-otpc whoever was first. > > [0] https://lore.kernel.org/lkml/550e652e-4541-c1e6-33a7-d5555f0cb266@xxxxxxxxxx/ > >> >> Thank you, >> Claudiu Beznea >> >>> >>> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx> >>> --- >>> arch/arm/boot/dts/lan966x.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi >>> index 23665a0429906..784caba369485 100644 >>> --- a/arch/arm/boot/dts/lan966x.dtsi >>> +++ b/arch/arm/boot/dts/lan966x.dtsi >>> @@ -163,6 +163,11 @@ port7: port@7 { >>> }; >>> }; >>> >>> + otp: otp@e0021000 { >>> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc"; >>> + reg = <0xe0021000 0x300>; >>> + }; >>> + >>> flx0: flexcom@e0040000 { >>> compatible = "atmel,sama5d2-flexcom"; >>> reg = <0xe0040000 0x100>; >> >
