On 25/11/2022 05:01, Samuel Holland wrote: > Some sunxi SoCs have in-package regulators controlled by a register in > the system control MMIO block. Allow a child node for this regulator > device in addition to SRAM child nodes. > > Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx> > --- > > Changes in v4: > - Remove unevaluatedProperties from regulators schema reference > > Changes in v3: > - Require the regulators node to have a unit address > - Reference the regulator schema from the SRAM controller schema > - Move the system LDOs example to the SRAM controller schema > - Reorder the patches so the example passes validation > > Changes in v2: > - New patch for v2 > > .../allwinner,sun4i-a10-system-control.yaml | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > index 98a7dc7f467d..c487ac9521e9 100644 > --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > @@ -56,6 +56,9 @@ properties: > ranges: true > > patternProperties: > + "^regulators@[0-9a-f]+$": > + $ref: /schemas/regulator/allwinner,sun20i-d1-system-ldos.yaml# > + > "^sram@[a-z0-9]+": > type: object You could add allOf:if:not:...then: clause making regulators as false for all variants which do not support it. This would make it more specific. Anyway: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
