On 2022/11/24 17:28, Conor Dooley wrote: > Hey Walker, > Just jumping in here... > > On Thu, Nov 24, 2022 at 05:08:57PM +0800, Walker Chen wrote: >> On 2022/11/19 2:31, Emil Renner Berthing wrote: >> > On Fri, 18 Nov 2022 at 14:35, Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> wrote: > >> >> diff --git a/include/soc/starfive/pm_domains.h b/include/soc/starfive/pm_domains.h >> >> new file mode 100644 >> >> index 000000000000..a20e28e9baf3 >> >> --- /dev/null >> >> +++ b/include/soc/starfive/pm_domains.h >> >> @@ -0,0 +1,15 @@ >> >> +/* SPDX-License-Identifier: GPL-2.0 */ >> >> +/* >> >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> >> + * Author: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >> >> + */ >> >> + >> >> +#ifndef __SOC_STARFIVE_PMDOMAINS_H__ >> >> +#define __SOC_STARFIVE_PMDOMAINS_H__ >> >> + >> >> +#include <linux/types.h> >> >> + >> >> +void starfive_pmu_hw_event_turn_on(u32 mask); >> >> +void starfive_pmu_hw_event_turn_off(u32 mask); >> >> + >> >> +#endif /* __SOC_STARFIVE_PMDOMAINS_H__ */ >> > >> > The header and functions within are named very generic, but >> > implemented by the jh71xx-specific driver. >> > >> > Also who should use this header? These functions are never called by >> > anything in this series. >> >> These two functions will be used by the GPU module. Only the power-off >> of the GPU is not controlled by the software through PMU module. So >> here the functions are needed to export. > > ...the general policy is to avoid adding things without users. I think > they should be kept as static functions for now & when your GPU driver > is being upstreamed you can expose these functions. That way your usage > of them can be reviewed with the appropriate context. > OK, thank you for your advice. I will modify the code according to your suggestion in the next version of patch. Best Regards, Walker Chen
