On Thu, 24 Nov 2022 at 06:56, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> wrote: > > On Sat, 19 Nov 2022 01:28:48 +0800, Emil Renner Berthing wrote: > > On Fri, 18 Nov 2022 at 02:17, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> wrote: > > > > > > From: Emil Renner Berthing <kernel@xxxxxxxx> > > > > > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > > > and the VisionFive2 board [2] equipped with it. > > > > > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > > > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html > > > > > > Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx> > > > Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > index 5b36243fd674..64008c57e31f 100644 > > > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > @@ -22,6 +22,10 @@ properties: > > > - const: beagle,beaglev-starlight-jh7100-r0 > > > - const: starfive,jh7100 > > > > > > + - items: > > > + - const: starfive,visionfive-v2 > > > > I think StarFive has switched to just calling it VisionFive 2 and not > > V2. Please check up on this before committing to the compatible > > string. > > > > Also there are going to be different revisions of the VisionFive 2 > > board, so maybe consider adding eg. starfive,visionfive-2-v1.1 and > > starfive,visionfive-2-v1,2b early. > > I checked that the official name of this board is "VisionFive 2". The > board has version A and version B, which are different in gmac and phy > chip. The version A board has one 1000M and one 100M Ethernet ports > while the version B board has two 1000M Ethernet ports. In dts, they > have different configuration parameters for gmac. So I would like to > distinguish them by two compatibles as below in the next version. > > - items: > - enum: > - starfive,visionfive-2-va > - starfive,visionfive-2-vb > - const: starfive,jh7110 Cool. Though the silkscreen on my board says "VisionFive 2 V1.2B" so I think it would be less confusing if you used that as the model, and "starfive,visionfive-2-v1.2b" as the compatible string for the board. > Best regards, > Hal > > > > > > + - const: starfive,jh7110 > > > + > > > additionalProperties: true >
