> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > Sent: 23 November 2022 18:43 > To: Sriranjani P <sriranjani.p@xxxxxxxxxxx>; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; lee@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx; ravi.patel@xxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node > > On 23/11/2022 12:57, Sriranjani P wrote: > > > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > >> Sent: 21 November 2022 17:58 > >> To: Sriranjani P <sriranjani.p@xxxxxxxxxxx>; robh+dt@xxxxxxxxxx; > >> krzysztof.kozlowski+dt@xxxxxxxxxx; lee@xxxxxxxxxx; > >> devicetree@xxxxxxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > >> pankaj.dubey@xxxxxxxxxxx; ravi.patel@xxxxxxxxxxx > >> Cc: linux-kernel@xxxxxxxxxxxxxxx > >> Subject: Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node > >> > >> On 21/11/2022 10:11, Sriranjani P wrote: > >>> Add SYSREG controller device node, which is available in PERIC, > >>> FSYS0 and > >>> FSYS1 block of FSD SoC. > >>> > >>> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> > >>> Signed-off-by: Sriranjani P <sriranjani.p@xxxxxxxxxxx> > >>> --- > >>> arch/arm64/boot/dts/tesla/fsd.dtsi | 15 +++++++++++++++ > >>> 1 file changed, 15 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi > >>> b/arch/arm64/boot/dts/tesla/fsd.dtsi > >>> index f35bc5a288c2..db78816ba0bf 100644 > >>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi > >>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi > >>> @@ -518,6 +518,21 @@ > >>> "dout_cmu_fsys1_shared0div4"; > >>> }; > >>> > >>> + sysreg_peric: syscon@14030000 { > >> > >> Node name system-controller > > [Sriranjani P] Will fix it in the next version. We added “syscon” since I > referred other dtsi files in mainline for example exynosautov9.dtsi used > syscon as node name. If this is the name we should add then I’ll post few > more patches fixing this node name in other Exynos dtsi files. > > Use proper wrapping for mailing lists. It's difficult to read your emails. Sorry for the confusion. I have fixed my email client now. > > >> and either put it next to existing one or next to functional block > >> (peric > >> clocks?) ordered by unit address. > > [Sriranjani P] We thought of it but as I saw current fsd.dtsi file and other > exynos file like exynosautov9.dtsi, in that nodes are not properly arranged as > per unit address. > > I know, that's why I proposed to order by unit address within other syscons > or other functional blocks (e.g. peric-related). Got it. I'll move the sysreg nodes near to their functional blocks and order them by unit address. > > > > > So I can think of following two approaches: > > 1: For the time being I will put this sysreg node in between > > clock_peric node and clock_fysys0 node and clock_fsys1 node as per > > increasing unit address. I will clean up other exynos and FSD DTSI > > files and post a new patch > > Not sure what cleaning you have in mind. > > > 2: First I will clean up exynos and FSD DTSI files and then post this sysreg > patch keeping it at appropriate place. > > What cleaning? By cleaning I meant fixing these dtsi files to have the device nodes in the order of ascending unit address. > > Best regards, > Krzysztof Thank you.
