On Wed, Nov 16, 2022 at 01:54:56PM +0000, daire.mcnamara@xxxxxxxxxxxxx wrote: > From: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx> > > Minor re-organisation so that macros representing registers ascend in > numerical order and use the same names as their hardware documentation. > Removed registers not used by the driver. > > Signed-off-by: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx> > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > --- > drivers/pci/controller/pcie-microchip-host.c | 122 +++++++++---------- > 1 file changed, 60 insertions(+), 62 deletions(-) > > diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c > index 0ebf7015e9af..80e7554722ca 100644 > --- a/drivers/pci/controller/pcie-microchip-host.c > +++ b/drivers/pci/controller/pcie-microchip-host.c > @@ -137,7 +78,8 @@ > #define ISTATUS_LOCAL 0x184 > #define IMASK_HOST 0x188 > #define ISTATUS_HOST 0x18c > -#define MSI_ADDR 0x190 > +#define IMSI_ADDR 0x190 > +#define MSI_ADDR 0x190 Trivial, trivial comment - I think it would look more intentional as: #define MSI_ADDR IMSI_ADDR Otherwise this seems grand to me, modulo the SoB issue. Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks, Conor.
