Re: [PATCH 2/2] drm/msm/disp/dpu1: add support for display on SM6115

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/11/2022 01:54, Dmitry Baryshkov wrote:
On 20/11/2022 15:37, Adam Skladowski wrote:
Add required display hw catalog changes for SM6115.

Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx>
---
  .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    | 87 +++++++++++++++++++
  .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h    |  1 +
  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |  1 +
  drivers/gpu/drm/msm/msm_mdss.c                |  5 ++
  4 files changed, 94 insertions(+)


[skipped]

diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
index 6a4549ef34d4..86b28add1fff 100644
--- a/drivers/gpu/drm/msm/msm_mdss.c
+++ b/drivers/gpu/drm/msm/msm_mdss.c
@@ -280,6 +280,10 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss)
          /* UBWC_2_0 */
          msm_mdss_setup_ubwc_dec_20(msm_mdss, 0x1e);
          break;
+    case DPU_HW_VER_630:
+        /* UBWC_2_0 */
+        msm_mdss_setup_ubwc_dec_20(msm_mdss, 0x11f);
+        break;

According to the vendor dtsi the sm6115 is UBWC 1.0, not 2.0

Could you please doublecheck?

Looks good to me otherwise.

After doublechecking:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>


      case DPU_HW_VER_720:
          msm_mdss_setup_ubwc_dec_40(msm_mdss, UBWC_3_0, 6, 1, 1, 1);
          break;
@@ -509,6 +513,7 @@ static const struct of_device_id mdss_dt_match[] = {
      { .compatible = "qcom,sc7180-mdss" },
      { .compatible = "qcom,sc7280-mdss" },
      { .compatible = "qcom,sc8180x-mdss" },
+    { .compatible = "qcom,sm6115-mdss" },
      { .compatible = "qcom,sm8150-mdss" },
      { .compatible = "qcom,sm8250-mdss" },
      {}


--
With best wishes
Dmitry




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux