Re: [PATCH v2 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge

[Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>]

On 23/11/2022 11:01, Krzysztof Kozlowski wrote:
> On 23/11/2022 00:36, Dmitry Baryshkov wrote:
> > From: Vinod Koul <vkoul@xxxxxxxxxx>
> >
> > Add the LT9611uxc DSI-HDMI bridge and supplies
> >
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
>
> > +
> >   &sdhc_2 {
> >   	cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>;
> >   	pinctrl-names = "default", "sleep";
> > @@ -431,6 +478,20 @@ &sdhc_2 {
> >   &tlmm {
> >   	gpio-reserved-ranges = <28 4>, <36 4>;
> >   
> > +	lt9611_irq_pin: lt9611-irq {
>
> -state suffix
>
> And test DTS against bindings (`make dtbs_check`).

Ack

> > +		pins = "gpio44";
> > +		function = "gpio";
> > +		bias-disable;
> > +	};
> > +
> > +	lt9611_rst_pin: lt9611-rst-state {
> > +		pins = "gpio107";
> > +		function = "normal";
> > +
> > +		output-high;
> > +		input-disable;

Also dropping input-disable and changing function to "gpio".

> > +	};
> > +
> >   	sdc2_card_det_n: sd-card-det-n-state {
> >   		pins = "gpio92";
> >   		function = "gpio";
>
> Best regards,
> Krzysztof

--
With best wishes
Dmitry