On 2022/11/23 22:21, neil.armstrong@xxxxxxxxxx wrote:
[ EXTERNAL EMAIL ]
On 23/11/2022 15:13, Krzysztof Kozlowski wrote:
On 23/11/2022 14:27, Neil Armstrong wrote:
On 23/11/2022 11:10, Krzysztof Kozlowski wrote:
On 23/11/2022 03:13, Yu Tu wrote:
Added information about the S4 SOC Peripheral Clock controller in DT.
Signed-off-by: Yu Tu <yu.tu@xxxxxxxxxxx>
---
arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 26
+++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
index bd9c2ef83314..e7fab6e400be 100644
--- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
@@ -6,6 +6,8 @@
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/clock/amlogic,s4-pll-clkc.h>
+#include <dt-bindings/clock/amlogic,s4-peripherals-clkc.h>
/ {
cpus {
@@ -100,6 +102,30 @@ clkc_pll: clock-controller@8000 {
#clock-cells = <1>;
};
+ clkc_periphs: clock-controller {
+ compatible = "amlogic,s4-peripherals-clkc";
+ reg = <0x0 0x0 0x0 0x49c>;
This is broken... did you check for warnings?
This is actually fine, the parent node has a ranges property:
https://github.com/torvalds/linux/blob/eb7081409f94a9a8608593d0fb63a1aa3d6f95d8/arch/arm64/boot/dts/amlogic/meson-s4.dtsi#L93
The parent ranges do not change here anything. You cannot have a reg
without unit address and the tools report it. No need to use reviewers
for this...
Oh I see now, I simply looked at the reg property, not the unit address.
Sorry indeed it's wrong and DTC should complain.
Yu, you should probably update your DTC version.
Okay.
Neil
Best regards,
Krzysztof
.
