Hi Anand, On 11/16/22 21:01, Anand Moon wrote: > Add support of external clock gmac1_clkin which is used as input clock > to ethernet node. Indeed this operating mode is defined in the schematics, thanks for the fix. > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> Reviewed-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> Tested-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> Best regards, Michael > --- > V2: None > --- > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > index e1c75532dcee..b848282ea005 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > @@ -32,6 +32,13 @@ hdmi_con_in: endpoint { > }; > }; > > + gmac1_clkin: external-gmac1-clock { > + compatible = "fixed-clock"; > + clock-frequency = <125000000>; > + clock-output-names = "gmac1_clkin"; > + #clock-cells = <0>; > + }; > + > leds { > compatible = "gpio-leds"; > > @@ -249,9 +256,8 @@ &cpu3 { > > &gmac1 { > assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>; > - assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>; > - assigned-clock-rates = <0>, <125000000>; > - clock_in_out = "output"; > + assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>, <&gmac1_clkin>; > + clock_in_out = "input"; > phy-handle = <&rgmii_phy1>; > phy-mode = "rgmii"; > pinctrl-names = "default"; > @@ -259,6 +265,7 @@ &gmac1 { > &gmac1m1_tx_bus2 > &gmac1m1_rx_bus2 > &gmac1m1_rgmii_clk > + &gmac1m1_clkinout > &gmac1m1_rgmii_bus>; > > tx_delay = <0x4f>;