On 2022/11/22 16:03, Krzysztof Kozlowski wrote: > On 22/11/2022 08:46, Walker Chen wrote: >> On 2022/11/21 18:12, Krzysztof Kozlowski wrote: >>> On 18/11/2022 14:32, Walker Chen wrote: >>>> Add power domain definitions for the StarFive JH7110 SoC. >>>> >>>> Signed-off-by: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >>>> --- >>>> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> create mode 100644 include/dt-bindings/power/jh7110-power.h >>>> >>>> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >>>> new file mode 100644 >>>> index 000000000000..24160c46fbaf >>>> --- /dev/null >>>> +++ b/include/dt-bindings/power/jh7110-power.h >>> >>> Filename matching compatible or bindings file. >> >> So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver >> should also be changed to "starfive,jh7110-power". Is it right ? > > I said filename should be changed. I don't remember what was your > compatible, but if I did not comment there, in means it looked fine. > >> >>> >>>> @@ -0,0 +1,18 @@ >>>> +/* SPDX-License-Identifier: (GPL-2.0) */ >>> >>> Dual license for bindings. >> >> Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. > > Any reasons why not using the licenses recommended by checkpatch? > Well, it sounds like a better way to decide which license to use by checkpatch. Thanks for your tip. Best Regards, Walker Chen
