On 21/11/2022 08:23, Sandor Yu wrote: > Add bindings for i.MX8MQ MHDP DisplayPort. > > Signed-off-by: Sandor Yu <Sandor.yu@xxxxxxx> > --- > .../display/bridge/cdns,mhdp-imx8mq-dp.yaml | 93 +++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > new file mode 100644 > index 000000000000..d82f3ceddaa8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp-imx8mq-dp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence MHDP Displayport bridge > + > +maintainers: > + - Sandor Yu <Sandor.yu@xxxxxxx> > + > +description: > + The Cadence MHDP Displayport TX interface. > + > +properties: > + compatible: > + enum: > + - cdns,mhdp-imx8mq-dp > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: MHDP DP APB clock. > + > + phys: > + maxItems: 1 > + > + interrupts: > + items: > + - description: Hotplug cable plugin. > + - description: Hotplug cable plugout. > + > + interrupt-names: > + items: > + - const: plug_in > + - const: plug_out > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input port from display controller output. > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port to DP connector. > + > + required: > + - port@0 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + - interrupt-names > + - phys > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/imx8mq-clock.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + mhdp_dp: dp-bridge@32c00000 { > + compatible = "cdns,mhdp-imx8mq-dp"; > + reg = <0x32c00000 0x100000>; > + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "plug_in", "plug_out"; > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + phys = <&dp_phy>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + mhdp_in: endpoint { > + remote-endpoint = <&dcss_out>; > + }; As Rob suggested, you allowed property for output to DP port. However it is not in the example. If this is a bridge, what does it bridge if there is no output connector? Best regards, Krzysztof