On 19.11.2022 21:27, Lin, Meng-Bo wrote: > FL8005A uses a Focaltech FT5402 touchscreen that is connected to > blsp_i2c5. Add it to the device tree. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@xxxxxxxxxxxxxx> > --- > .../boot/dts/qcom/msm8916-gplus-fl8005a.dts | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts b/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts > index bed1fe984287..cc81880f7c42 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts > +++ b/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts > @@ -65,6 +65,32 @@ usb_id: usb-id { > }; > }; > > +&blsp_i2c5 { > + status = "okay"; > + > + touchscreen@38 { > + /* Actually ft5402 */ > + compatible = "edt,edt-ft5406"; > + reg = <0x38>; > + > + interrupt-parent = <&msmgpio>; > + interrupts = <13 IRQ_TYPE_EDGE_FALLING>; > + > + reset-gpios = <&msmgpio 12 GPIO_ACTIVE_LOW>; > + > + vcc-supply = <&pm8916_l17>; > + iovcc-supply = <&pm8916_l6>; > + > + touchscreen-size-x = <800>; > + touchscreen-size-y = <500>; > + touchscreen-inverted-x; > + touchscreen-swapped-x-y; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&touchscreen_default>; > + }; > +}; > + > &blsp1_uart2 { > status = "okay"; > }; > @@ -229,6 +255,24 @@ gpio_leds_default: gpio-led-default-state { > bias-disable; > }; > > + touchscreen_default: touchscreen-default-state { > + touchscreen-pins { > + pins = "gpio13"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + reset-pins { > + pins = "gpio12"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-disable; > + }; These subnodes are not sorted in any way, neither alphabetically nor GPIO-no wise. Please swap them. With that: Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > + }; > + > usb_id_default: usb-id-default-state { > pins = "gpio110"; > function = "gpio";