On 20/11/2022 09:21, Jisheng Zhang wrote: > Add bindings doc for Bouffalolab UART Driver Subject: drop second, redundant "bindings doc". > > Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx> > --- > .../bindings/serial/bouffalolab,uart.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > > diff --git a/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > new file mode 100644 > index 000000000000..6cef956d33d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/bouffalolab,uart.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 Jisheng Zhang <jszhang@xxxxxxxxxx> > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/serial/bouffalolab,uart.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" Drop quotes from both lines. > + > +title: Bouffalolab UART Controller > + > +maintainers: > + - Jisheng Zhang <jszhang@xxxxxxxxxx> > + > +allOf: > + - $ref: serial.yaml# > + > +properties: > + compatible: > + const: bouffalolab,uart No model number? From bouffalolab there will be only one, exactly UART model? No new models in next 5, 10, 100 years? > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + aliases { > + serial0 = &uart0; > + }; Drop aliases, not related. Best regards, Krzysztof