On 18/11/2022 19:26, Melody Olvera wrote: > Add compatible for scm driver for QDU1000 and QRU1000 platforms. These drivers > only require the compatible field, so update the bindings accordingly for > these platforms. > > Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> > --- > This patch is separated out from [1] and includes > changes addressing comments from that patch set. > > [1] https://lore.kernel.org/all/20221026190549.4005703-2-quic_molvera@xxxxxxxxxxx/ Then this is a v4. Please always include the changelog. Did you implement the changes requested? If they are no changes, then review would stay the same as before. > > .../devicetree/bindings/firmware/qcom,scm.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index 25688571ee7c..71012d43a32f 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -38,6 +38,7 @@ properties: > - qcom,scm-msm8994 > - qcom,scm-msm8996 > - qcom,scm-msm8998 > + - qcom,scm-qdu1000 > - qcom,scm-sc7180 > - qcom,scm-sc7280 > - qcom,scm-sc8280xp > @@ -82,6 +83,16 @@ properties: > description: TCSR hardware block > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: qcom,scm-qdu1000 > + then: > + properties: > + clocks: false > + clock-names: false > + > - if: > properties: > compatible: > > base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67 Best regards, Krzysztof