On Fri, Nov 18, 2022 at 5:11 AM Andrew Lunn <andrew@xxxxxxx> wrote: > > > Andrew, > > > > I completely agree with you but I haven't seen how that can be done > > yet. What support exists for a PHY driver to expose their LED > > configuration to be used that way? Can you point me to an example? > > Nobody has actually worked on this long enough to get code merged. e.g. > https://lore.kernel.org/netdev/20201004095852.GB1104@bug/T/ > https://lists.archive.carbon60.com/linux/kernel/3396223 > > This is probably the last attempt, which was not too far away from getting merged: > https://patches.linaro.org/project/linux-leds/cover/20220503151633.18760-1-ansuelsmth@xxxxxxxxx/ > > I seem to NACK a patch like yours every couple of months. If all that > wasted time was actually spent on a common framework, this would of > been solved years ago. > > How important is it to you to control these LEDs? Enough to finish > this code and get it merged? > Andrew, Thanks for the links - the most recent attempt does look promising. For whatever reason I don't have that series in my mail history so it's not clear how I can respond to it. Ansuel, are you planning on posting a v7 of 'Adds support for PHY LEDs with offload triggers' [1]? I'm not all that familiar with netdev led triggers. Is there a way to configure the default offload blink mode via dt with your series? I didn't quite follow how the offload function/blink-mode gets set. Best Regards, Tim [1] https://patches.linaro.org/project/linux-leds/list/?submitter=10040
