On Wed, Nov 16, 2022 at 11:49 AM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: > > On Thu, Nov 10, 2022 at 10:49:45AM +0100, Uwe Kleine-König wrote: > [...] > > new file mode 100644 > > index 000000000000..c3cf6f92a766 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml > > @@ -0,0 +1,110 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/imx/fsl,imx-lcdc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale i.MX LCD Controller, found on i.MX1, i.MX21, i.MX25 and i.MX27 > > + > > +maintainers: > > + - Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > + - Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - fsl,imx1-fb > > + - fsl,imx21-fb > > Are the items/enum keywords superfluous here? Couldn't this just be two > > - const: fsl,imx1-fb > - const: fsl,imx21-fb > > entries? mx1 is backwards compatible with mx21? No. Rob
