On Thu, Nov 17, 2022 at 01:14:00PM +0100, Krzysztof Kozlowski wrote: > On 03/11/2022 10:57, Manivannan Sadhasivam wrote: > > As per the new ADC7 architecture used by the Qualcomm PMICs, each PMIC > > has the static Slave ID (SID) assigned by default. The primary PMIC > > PMK8350 is responsible for collecting the temperature/voltage data from > > the slave PMICs and exposing them via it's registers. > > > > For getting the measurements from the slave PMICs, PMK8350 uses the > > channel ID encoded with the SID of the relevant PMIC. So far, the > > dt-binding for the slave PMIC PM8350 assumed that there will be only > > one PM8350 in a system. So it harcoded SID 1 with channel IDs. > > > > But this got changed in platforms such as Lenovo X13s where there are a > > couple of PM8350 PMICs available. So to address multiple PM8350s, change > > the binding to accept the SID specified by the user and use it for > > encoding the channel ID. > > > > It should be noted that, even though the SID is static it is not > > globally unique. Only the primary PMIC has the unique SID id 0. > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > --- > > This was never sent to IIO maintainers, so now next is failing. > I missed it since there was only one bindings patch and rest all were dts :/ > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > The problem was that I didn't rebase my patches on top of linux-next/Bjorn's for-next at that time but used v6.1-rcX. So I did not see the example in spmi-vadc. Thanks, Mani > Best regards, > Krzysztof > -- மணிவண்ணன் சதாசிவம்
