Hi Rob, Srinivas, robh@xxxxxxxxxx wrote on Wed, 16 Nov 2022 14:52:03 -0600: > On Mon, Nov 14, 2022 at 09:56:57AM +0100, Miquel Raynal wrote: > > From: Michael Walle <michael@xxxxxxxx> > > > > Add a schema for the NVMEM layout on Kontron's sl28 boards. > > > > Signed-off-by: Michael Walle <michael@xxxxxxxx> > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > --- > > .../nvmem/layouts/kontron,sl28-vpd.yaml | 62 +++++++++++++++++++ > > .../bindings/nvmem/layouts/nvmem-layout.yaml | 3 + > > 2 files changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml > > > > diff --git a/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml > > new file mode 100644 > > index 000000000000..fef795e79c36 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml > > @@ -0,0 +1,62 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/nvmem/layouts/kontron,sl28-vpd.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NVMEM layout of the Kontron SMARC-sAL28 vital product data > > + > > +maintainers: > > + - Michael Walle <michael@xxxxxxxx> > > + > > +description: > > + The vital product data (VPD) of the sl28 boards contains a serial > > + number and a base MAC address. The actual MAC addresses for the > > + on-board ethernet devices are derived from this base MAC address by > > + adding an offset. > > + > > +select: false > > + > > +properties: > > + compatible: > > + const: kontron,sl28-vpd > > + > > + serial-number: > > + type: object > > additionalProperties: false Right, I missed that one. > With that, > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Thanks for all the reviews! Srinivas, would you add the above property while applying or do you prefer me to send a v5? Thanks, Miquèl
